-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux node selector to bundleUnpacker job #2685
Conversation
Hi @aimichelle. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@joelanford, @njhale , would either of you be able to take a look? Thank you! |
/ok-to-test |
/lgtm |
@aimichelle could you please update fix the failing unit test? FYI, I've rebased from this side. |
Thank you! Just pushed changes to the tests. Let me know if there's anything else you need. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Michelle Nguyen <michellenguyen@pixielabs.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aimichelle, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Signed-off-by: Michelle Nguyen michellenguyen@pixielabs.ai
Description of the change: Added default nodeSelector
"kubernetes.io/os": "linux"
to the bundle unpacker job's pod template.Motivation for the change: For the most part, we've noticed that OLM does a good job of adding the
"kubernetes.io/os": "linux"
node selector by default to most of the K8s resources it deploys. However, we've noticed the bundle unpacker job does not have any nodeSelector applied to it. In multi-OS environments, this can be a problem if this job starts up on a non-linux nodes.Reviewer Checklist
/doc
[FLAKE]
are truly flaky[FLAKE]
tag are no longer flaky