Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(psa) add unit test cases for registry pod config #2860

Merged
merged 1 commit into from
Sep 15, 2022
Merged

(psa) add unit test cases for registry pod config #2860

merged 1 commit into from
Sep 15, 2022

Conversation

anik120
Copy link
Contributor

@anik120 anik120 commented Sep 14, 2022

This PR adds unit tests to test the pod+container securityContext configs introduced in #2854

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@anik120 anik120 requested review from bparees and removed request for timflannagan September 14, 2022 19:52
@bparees
Copy link

bparees commented Sep 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@anik120 anik120 force-pushed the registry-pod-securityContext-unit-tests branch from aa6435a to e89aeba Compare September 14, 2022 21:16
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@anik120
(psa) add unit test cases for registry pod config
bda476d 
This PR adds unit tests to test the pod+container securityContext configs
introduced in operator-framework#2854

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
@anik120 anik120 force-pushed the registry-pod-securityContext-unit-tests branch from e89aeba to bda476d Compare September 15, 2022 01:51
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@oceanc80
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@grokspawn
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 71f128a into operator-framework:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford Awaiting requested review from joelanford

@bparees bparees Awaiting requested review from bparees

Assignees

@bparees bparees

@oceanc80 oceanc80

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anik120 @bparees @grokspawn @oceanc80 @openshift-merge-robot