Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change opm image from quay.io/operator-framework/upstream-opm-builder to quay.io/operator-framework/opm #2890

Merged

Conversation

StopMotionCuber
Copy link
Contributor

Description of the change: Bumping the opm image from quay.io/operator-framework/upstream-opm-builder to quay.io/operator-framework/opm

Motivation for the change: We are having issues with opm jobs, as we have a multi-arch cluster, where jobs are failing if ran on ARM64 nodes. The OLM seems to be using a deprecated opm image. See details in #2823 (comment)

Note: I don't completely know what I'm doing and whether the opm image is actually able to fully replace the upstream-opm-builder image. But I guess before digging down deeply into that rabbit hole, maintainers here should have a good understanding of that and evaluate that quicker than me.
Closes #2823

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 10, 2022

Hi @StopMotionCuber. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -8,7 +8,7 @@ import (
)

const (
defaultBinarySourceImage = "quay.io/operator-framework/upstream-opm-builder"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be directly changed. Instead, it seems we need OLM to bump its operator-registry version in go.mod and then re-vendor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the re-vendoring would have done the same string replacement. Anyway, I force-pushed that change away, is the vendoring done automatically? I guess yes, as there is a "vendor" step in the workflows

@StopMotionCuber
Copy link
Contributor Author

Wanted to check-in if there is something blocking this from being merged, as it has been 5 month now. This seems to be blocking ARM64 support, though it can be patched locally on the cluster by overriding the image

Copy link
Collaborator

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva, StopMotionCuber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
…r` to `quay.io/operator-framework/opm`

Signed-off-by: Ruben Simons <r.simons@fz-juelich.de>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@StopMotionCuber
Copy link
Contributor Author

Had to fix DCO, should be good now

@perdasilva
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit f5a8757 into operator-framework:master Apr 13, 2023
@lukens
Copy link

lukens commented May 3, 2023

Any idea when this might make it into a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operatorhub Catalog ARM64 Support
5 participants