Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWNERS: Remove timflannagan as reviewer/approver #2899

Merged
merged 1 commit into from
Nov 30, 2022
Merged

OWNERS: Remove timflannagan as reviewer/approver #2899

merged 1 commit into from
Nov 30, 2022

Conversation

timflannagan
Copy link
Contributor

Signed-off-by: timflannagan timflannagan@gmail.com

Description of the change:

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci
Copy link

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@timflannagan
OWNERS: Remove timflannagan as reviewer/approver
76623c8 
Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan timflannagan force-pushed the owners/remove-tflannag branch from 2908d29 to 76623c8 Compare November 30, 2022 15:35
@exdx
Copy link
Member

exdx commented Nov 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6ffec4d into operator-framework:master Nov 30, 2022
@timflannagan timflannagan deleted the owners/remove-tflannag branch November 30, 2022 18:08
@grokspawn
Copy link
Contributor

/lgtm

Hi Dan!

@exdx
Copy link
Member

exdx commented Dec 3, 2022

/lgtm

Hi Dan!

Hey @grokspawn! Hope all is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@exdx exdx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timflannagan @exdx @grokspawn @openshift-merge-robot