Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: emit helpful comments as logs #3137

Merged
merged 1 commit into from
Dec 20, 2023
Merged

test/e2e: emit helpful comments as logs #3137

merged 1 commit into from
Dec 20, 2023

Conversation

stevekuznetsov
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from akihikokuroda and ncdc December 20, 2023 16:56
@stevekuznetsov
Copy link
Member Author 

   It looks like you are calling By outside of a running spec.  Make sure you
  call By inside a runnable node such as It or BeforeEach and not inside the
  body of a container such as Describe or Context.

@stevekuznetsov
Copy link
Member Author

:eyeroll:

@stevekuznetsov
test/e2e: emit helpful comments as logs
c3fa3d6 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@ncdc
Copy link
Member

ncdc commented Dec 20, 2023

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@ncdc ncdc enabled auto-merge December 20, 2023 18:55
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ncdc ncdc added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit e30e6f4 into operator-framework:master Dec 20, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncdc ncdc ncdc approved these changes

@akihikokuroda akihikokuroda Awaiting requested review from akihikokuroda

Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevekuznetsov @ncdc