Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up: remove run-kind-local and run-minikube-local GitHub Actions #3216

Merged
merged 1 commit into from
May 3, 2024
Merged

clean-up: remove run-kind-local and run-minikube-local GitHub Actions #3216

merged 1 commit into from
May 3, 2024

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented May 3, 2024 •
edited
Loading

Description of the change:
Removes run-kind-local and run-minikube-local github actions

Motivation for the change:
They don't add much value since the e2es are anyway executed on kind

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from anik120 and tmshort May 3, 2024 15:37
remove run-kind and run-minikube github actions
2d7f1f6 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the drop_minikube_kind_jobs branch from edce104 to 2d7f1f6 Compare May 3, 2024 15:37
@perdasilva perdasilva changed the title clean-up: remove run-kind and run-minikube GitHub Actions clean-up: remove run-kind-local and run-minikube-local GitHub Actions May 3, 2024
@joelanford joelanford added this pull request to the merge queue May 3, 2024
Merged via the queue into operator-framework:master with commit 157af32 May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@anik120 anik120 Awaiting requested review from anik120

@tmshort tmshort Awaiting requested review from tmshort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perdasilva @joelanford