Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource limits for ansible #5274

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Oct 2, 2021

Description of the change:
For Ansible-based operators, add default resource requests and limits for the manager now that the kustomize values were increased and increased the memory ones.

PS.: We are also increasing the number of tries to do molecule checks to avoid test flakes.

Motivation for the change:
Closes: #3573

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from asmacdo and jberkhahn October 2, 2021 22:35
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch 2 times, most recently from 62356b4 to 1d206e6 Compare October 2, 2021 22:57
@camilamacedo86 camilamacedo86 changed the title feat: add resource limits for ansible WIP: feat: add resource limits for ansible Oct 2, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch 4 times, most recently from c71b6bd to a67d51a Compare October 3, 2021 00:26
@camilamacedo86
Copy link
Contributor Author

c/c @fgiloux (fyi)

@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from a67d51a to 187f48c Compare October 3, 2021 00:27
@camilamacedo86 camilamacedo86 changed the title WIP: feat: add resource limits for ansible feat: add resource limits for ansible Oct 3, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from 187f48c to 763de99 Compare October 3, 2021 00:54
@camilamacedo86 camilamacedo86 changed the title feat: add resource limits for ansible WIP: feat: add resource limits for ansible Oct 3, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from f300579 to 41fe855 Compare October 4, 2021 20:15
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from 41fe855 to e43736d Compare November 28, 2021 09:01
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch 2 times, most recently from 29775fb to 530e23c Compare November 28, 2021 14:39
@camilamacedo86 camilamacedo86 changed the title WIP: feat: add resource limits for ansible feat: add resource limits for ansible Nov 28, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2021
@camilamacedo86

This comment has been minimized.

@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch 2 times, most recently from 234d8ea to ef8d27b Compare December 7, 2021 16:24
@camilamacedo86 camilamacedo86 changed the title feat: add resource limits for ansible WIP: feat: add resource limits for ansible Dec 8, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from 6eeccbc to f1f43a1 Compare December 17, 2021 16:03
@camilamacedo86 camilamacedo86 changed the title WIP: feat: add resource limits for ansible feat: add resource limits for ansible Dec 17, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from f1f43a1 to e0da74e Compare December 17, 2021 16:10
Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left an optional suggestion
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2021
@camilamacedo86 camilamacedo86 force-pushed the add-ansible-resources-limits branch from e0da74e to 0832312 Compare January 6, 2022 11:04
@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2022
@camilamacedo86 camilamacedo86 merged commit e62537c into operator-framework:master Jan 6, 2022
@camilamacedo86 camilamacedo86 deleted the add-ansible-resources-limits branch January 6, 2022 13:55
@camilamacedo86
Copy link
Contributor Author

Merging these ones since the values/amounts were aligned with @fabianvf and @asmacdo.
And are the values that allowed us to run all e2e tests without compromising its performance/time.
Note that just the python interpreter alone usually takes ~64Mi and there are two of them running at any given time.

c/c @fgiloux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource limits to Ansible operator scaffolding
4 participants