Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile some assets without a digest #1379

Merged
merged 2 commits into from
May 28, 2014
Merged

Precompile some assets without a digest #1379

merged 2 commits into from
May 28, 2014

Conversation

myabc
Copy link
Contributor

@myabc myabc commented May 28, 2014

* #8228 Icons in select2 elements missing

rails/sprockets-rails#49 includes discussion of some of the issues surrounding this PR.

myabc added 2 commits May 28, 2014 11:28
This is a transitionary measure that allows us to precompile certain
assets without a digest. The README provides an explanation of the use
cases for which this is needed:
https://github.com/alexspeller/non-stupid-digest-assets/blob/master/README.md#but-shouldnt-i-always-use-the-rails-asset-helpers-anyway

[ci skip]

Signed-off-by: Alex Coles <alex@alexbcoles.com>
Bug # 8228

[ci skip]

Signed-off-by: Alex Coles <alex@alexbcoles.com>
@myabc
Copy link
Contributor Author

myabc commented May 28, 2014

Note: this is an interim solution. Official "best practice" is for us to copy vendor stylesheets into our own project, replacing url() with the relevant asset helper (image-url(), etc.)

@hschink hschink merged commit 2bd192c into dev May 28, 2014
@hschink hschink deleted the fix/non-digest-assets branch May 28, 2014 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants