ansible-oracle: BREAKING CHANGE! move to a collection

.ansible-lint

@@ -1,15 +1,11 @@
 ---
+
 use_default_rules: true
 
-skip_list:
-  - role-name
-  # must be fixed at later time
-  - var-naming
-  # temporary deactived - will be removed in next PRs
-  - fqcn-builtins
-  - schema
+# skip_list:
 
 exclude_paths:
   - .github
   - dbhome-conversion
-  - library
+  - plugins/modules
+  - playbooks

.pre-commit-config.yaml

@@ -16,7 +16,7 @@ repos:
       - id: forbid-new-submodules
 
   - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v5.2.0
+    rev: v6.3.0
     hooks:
       - id: ansible-lint
         entry: ansible-lint --force-color -p

README.md

@@ -7,10 +7,11 @@
 
 Pre-requisites:
 
-- Ansible >= 2.4
+- Ansible >= 2.9
 - Oracle Linux (or any RHEL-based Linux System) >= 6.4
-- Oracle Database/Grid Infrastructure 18.3.0.0, 12.2.0.1, 12.1.0.1, 12.1.0.2, 11.2.0.4, 11.2.0.3
+- Oracle Database/Grid Infrastructure 21.3.0.0, 19.3.0.0, 18.3.0.0, 12.2.0.1, 12.1.0.1, 12.1.0.2
 - For example configurations, look in:
+
 ```
   SI/FS:   group_vars/vbox-si-fs.  - vagrant config: http://github.com/oravirt/vagrant-vbox-si-fs
   SI/ASM:  group_vars/vbox-si-asm  - vagrant config: http://github.com/oravirt/vagrant-vbox-si-asm
@@ -26,10 +27,11 @@ By default, installs a single instance 18.3.0.0 database on a filesystem.
    - `LINUX.X64_180000_db_home.zip`
 
 3. Create an Ansible inventory file
-   ```
+
+```
    [myhostgroup]
     dbhost
-   ```
+```
 
 4. Run the playbook:
 

galaxy.yml

@@ -0,0 +1,12 @@
+---
+namespace: opitzconsulting
+name: ansible_oracle
+description: This is the collection of ansible-oracle from Branch oc on https://github.com/opitzconsulting/ansible-oracle
+version: 3.0.0
+readme: README.md
+authors:
+  - Mikael Sandström
+  - OPITZ CONSULTING
+  - Thorsten Bruhns
+tags:
+  - oracle

group_vars/vbox-si-fs/vbox-si-fs.yml → inventory/group_vars/vbox-si-fs/vbox-si-fs.yml

@@ -19,7 +19,7 @@ configure_epel_repo: false
 configure_public_yum_repo: false
 disable_selinux: false
 
-disable_EE_options: false
+disable_ee_options: false  # noqa var-naming
 
 
 host_fs_layout:

aws-si-asm-install.yml → playbooks/aws-si-asm-install.yml

@@ -9,25 +9,25 @@
   roles:
     - common
     - orahost
-    - orahost-storage
+    - orahost_storage
 
 - name: Oracle Grid Infrastructure installation & ASM Configuration
   hosts: aws-si-asm
   connection: local
   user: ec2-user
   become: true
   roles:
-    - oraswgi-install
-    - oraasm-createdg
+    - oraswgi_install
+    - oraasm_createdg
 
 - name: Database Server Installation & Database Creation
   hosts: aws-si-asm
   connection: local
   user: ec2-user
   become: true
   roles:
-    - oraswdb-install
-    - oradb-manage-db
+    - oraswdb_install
+    - oradb_manage_db
 
 - name: Install cx_oracle
   hosts: aws-si-asm
@@ -43,4 +43,4 @@
   user: ec2-user
   become: true
   roles:
-    - orahost-logrotate
+    - orahost_logrotate

playbooks/customize-db.yml

@@ -0,0 +1,13 @@
+---
+- name: Customize database
+  hosts: "{{ hostgroup | default('all') }}"
+  become: true
+  roles:
+    - oradb_manage_pdb
+    - oradb_manage_tablespace
+    - oradb_manage_parameters
+    - oradb_manage_redo
+    - oradb_manage_roles
+    - oradb_manage_users
+    - oradb_manage_grants
+    - oradb_manage_services

db-opatch.yml → playbooks/db-opatch.yml

@@ -4,10 +4,10 @@
   become: true
   serial: 1
   roles:
-    - {role: oraswdb-manage-patches}
+    - {role: oraswdb_manage_patches}
 
 - name: Run datapatch
   hosts: "{{ hostgroup | default('all') }}"
   become: true
   roles:
-    - {role: oradb-datapatch}
+    - {role: oradb_datapatch}

delete-db.yml → playbooks/delete-db.yml

@@ -7,4 +7,4 @@
   become: true
   become_user: oracle
   roles:
-    - oradb-delete
+    - oradb_delete

drracattack-full-install.yml → playbooks/drracattack-full-install.yml

@@ -10,18 +10,18 @@
   hosts: drracattack-hub
   user: root
   roles:
-    - orahost-storage
+    - orahost_storage
 
 - name: Oracle Grid Infrastructure installation
   hosts: drracattack
   user: root
   roles:
-    - oraswgi-install
+    - oraswgi_install
 
 - name: ASM Configuration, Database Server Installation & Database Creation
   hosts: drracattack-hub
   user: root
   roles:
-    - oraasm-createdg
-    - oraswdb-install
+    - oraasm_createdg
+    - oraswdb_install
     # - oradb-create

full-rac-flex-install.yml → playbooks/full-rac-flex-install.yml

@@ -12,20 +12,20 @@
   user: ansible
   become: true
   roles:
-    - orahost-storage
+    - orahost_storage
 
 - name: Oracle Grid Infrastructure installation
   hosts: orarac-flex
   user: ansible
   become: true
   roles:
-    - oraswgi-install
+    - oraswgi_install
 
 - name: ASM Configuration, Database Server Installation & Database Creation
   hosts: orarac-flex-hub
   user: ansible
   become: true
   roles:
-    - oraasm-createdg
-    - oraswdb-install
-    - oradb-create
+    - oraasm_createdg
+    - oraswdb_install
+    - oradb_create

full-rac-install-dc1.yml → playbooks/full-rac-install-dc1.yml

@@ -7,36 +7,36 @@
   roles:
     - common
     - orahost
-    - orahost-storage
+    - orahost_storage
 
 - name: ssh configuration
   hosts: vbox-rac-dc1
   user: vagrant
   become: true
   serial: 1
   roles:
-    - {role: orahost-ssh, when: configure_cluster and not old_ssh_config}
+    - {role: orahost_ssh, when: configure_cluster and not old_ssh_config}
 
 - name: Oracle Grid Infrastructure installation & ASM Configuration
   hosts: orarac-dc1
   user: ansible
   become: true
   roles:
-    - oraswgi-install
-    - oraasm-createdg
+    - oraswgi_install
+    - oraasm_createdg
 
 - name: Database Server Installation & Database Creation
   hosts: orarac-dc1
   user: ansible
   become: true
   roles:
-    - oraswdb-install
-    - oradb-create
+    - oraswdb_install
+    - oradb_create
 
 - name: Tweaks
   hosts: orarac-dc1
   user: ansible
   become: true
   roles:
     - cxoracle
-    - orahost-logrotate
+    - orahost_logrotate

gi-opatch.yml → playbooks/gi-opatch.yml

@@ -4,4 +4,4 @@
   become: true
   serial: 1
   roles:
-    - {role: oraswgi-manage-patches}
+    - {role: oraswgi_manage_patches}

manage-db.yml → playbooks/manage-db.yml

@@ -4,4 +4,4 @@
   hosts: "{{ hostgroup | default('all') }}"
   become: true
   roles:
-    - oradb-manage-db
+    - oradb_manage_db

racattack-full-install.yml → playbooks/racattack-full-install.yml

@@ -10,18 +10,18 @@
   hosts: racattack-hub
   user: root
   roles:
-    - orahost-storage
+    - orahost_storage
 
 - name: Oracle Grid Infrastructure installation
   hosts: racattack
   user: root
   roles:
-    - oraswgi-install
+    - oraswgi_install
 
 - name: ASM Configuration, Database Server Installation & Database Creation
   hosts: racattack-hub
   user: root
   roles:
-    - oraasm-createdg
-    - oraswdb-install
-    - oradb-create
+    - oraasm_createdg
+    - oraswdb_install
+    - oradb_create

single-instance-db-on-asm.yml → playbooks/single-instance-db-on-asm.yml

@@ -7,33 +7,33 @@
   roles:
     - common
     - orahost
-    - orahost-storage
+    - orahost_storage
 
 - name: Oracle Grid Infrastructure installation & ASM Configuration
   hosts: "{{ hostgroup }}"
   become: true
   roles:
-    - oraswgi-install
-    - oraasm-createdg
+    - oraswgi_install
+    - oraasm_createdg
 
 - name: Database Server Installation & Database Creation
   hosts: "{{ hostgroup | default('all') }}"
   become: true
   roles:
-    - oraswdb-install
-    - oradb-manage-db
+    - oraswdb_install
+    - oradb_manage_db
 
 - name: Tweaks
   become: true
   hosts: "{{ hostgroup | default('all') }}"
   roles:
     - cxoracle
-    - orahost-logrotate
+    - orahost_logrotate
 
 # - name: Database configuration (tablespaces, parameters etc)
 #   hosts: "{{ hostgroup }}"
 #   become: yes
 #   roles:
-#       - oradb-parameters
-#       - oradb-tablespace
-#       - oradb-users
+#       - oradb_parameters
+#       - oradb_tablespace
+#       - oradb_users

single-instance-db-on-fs.yml → playbooks/single-instance-db-on-fs.yml

@@ -13,5 +13,5 @@
   hosts: "{{ hostgroup }}"
   become: true
   roles:
-    - oraswdb-install
-    - oradb-manage-db
+    - oraswdb_install
+    - oradb_manage_db