Expose swingRating again (#34) #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I knew this weird way of doing it was going to bite me some day. Thank you for spotting and fixing it. Sorry for taking so long to review these. As I mentioned on Discord I was in the process of getting a headset and things ended up getting delayed more than I wish they did. |
opl-
added a commit
that referenced
this pull request
Jun 4, 2020
Adds: - `performance.cutDistanceScore` (#37, by @ErisApps) - `beatmap.levelId` containing the raw level ID (#40, by @ErisApps) - Note data in `bombMissed` and `noteMissed` events (see protocol.md) Fixes: - Expose `noteCut.swingRating` again (#36, by @ErisApps, broken since v1.8.0/a128c1) - Add `performance.cutDistanceScore` to both `performance.initialScore` and `performance.finalScore` (#37, by @ErisApps) - Fix `beatmap.songHash` (#40, by @ErisApps) - `obstacleEnter` and `obstacleExit` events not sent (#42, thanks @ErisApps, broken since v1.8.0) - Song cover not sent in the `songStart` event if it wasn't already cached, for example when the song is started programatically (see 311397 for details)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the swingRating field again.
It was still being calculated in-memory, but due to a missing mapping, it wasn't visible in the actual WS events.