Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a problem with 'songHash' when the same map exists #44

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

rynan4818
Copy link
Contributor

We have corrected the following Issues and confirmed that there are no problems.
https://github.com/opl-/beatsaber-http-status/issues/43
Please correct any errors in the English text of your corrected comment.

@ErisApps
Copy link
Contributor

ErisApps commented Jun 6, 2020

I've quickly checked the new magic number against the beatsaver database dump that I keep in sync locally and it seems that 40 is indeed the only length for a songHash so far (across all 28141 currently existing beatmaps) so that number seems to be correct.

@rynan4818
Copy link
Contributor Author

The current value of songHash is the SHA-1 hash value that combines all the beatmap data into a It has become.

Example.

This map's songHash is a
https://beatsaver.com/beatmap/93f9

Score Saber's ID says F3ED739066F90D59477B3E3F71 FC11E76963126B
https://scoresaber.com/leaderboard/215433

You can use this map data in

copy /b info.dat + HardStandard.dat + ExpertStandard.dat + ExpertPlusStandard.dat + Lightshow.dat test.dat

The SHA-1 hash value of the file combined with the above command is the same as the ID.

image

The SHA-1 hash is a fixed 160-bit value, so a fixed value of 40 characters is fine.

@opl- opl- merged commit 49226ad into opl-:master Jun 6, 2020
@opl-
Copy link
Owner

opl- commented Jun 6, 2020

Nice catch and thank you for the fix.

opl- added a commit that referenced this pull request Jun 7, 2020
Fixes:
- `beatmap.songHash` includes erroneous characters when multiple map directories have the same hash (#44, by @rynan4818)
@rynan4818 rynan4818 deleted the songHash_fix branch June 7, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants