Fix missing score data in solo play after playing a map in multiplayer, Fix errors when starting the tutorial #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip song setup in tutorial to avoid errors
|
Is there any reason you're grabbing the first object when in multiplayer and last in other cases, instead of simply always grabbing the last object? |
|
Yeah - tried that first and it didn't work. I think there is a a score controller floating around for every player in MP? Don't quote me on that one. I can try to look into that a bit more today. Also, if you think there is a better way to implement handling solo play after a multi session, feel free to disregard this PR and take it as a bug report. |
opl-
added a commit
that referenced
this pull request
Sep 24, 2021
Co-authored-by: Shadnix <shadnix@arcor.de>
opl-
added a commit
that referenced
this pull request
Sep 24, 2021
Co-authored-by: Shadnix <shadnix@arcor.de>
|
I effectively used your approach, but slightly rewritten and including some types you missed. Added you as a co-author to those commits. Thanks! |
opl-
added a commit
that referenced
this pull request
Sep 24, 2021
Adds: - `beatmap.color` representing the colors used by the environment. See [protocol.md] for more information. Fixes: - Playing multiplayer causes future maps played in singleplayer to not fire events correctly. (#74) - Tutorial should no longer cause exceptions to be logged. (#74) - levelFailed callback not unregistered correctly from the gameplay manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing a map in multiplayer mode, a couple of game objects (for example the ScoreController) linger around until the next game restart. When going back to solo play after playing a map in multiplayer, HTTP Status currently grabs the multiplayer objects and as a result is not getting certain data for the solo map.
Steps to reproduce with the layout by Reselim:
This PR should fix at least part of it. There might be more cases of getting the wrong object, as I only tested with the data that was available on the old Reselim overlay.
This PR also adds an additional check if the level data is present in BS_Utils on HandleSongStart. HTTP Status currently throws multiple different errors when starting the tutorial (also different depending if the player played a map in multplayer before starting the tutorial) and this fixes it by doing nothing when entering the tutorial.