Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find wrong keys with ide-extension #1057

Closed
NilsJacobsen opened this issue Jul 11, 2023 · 3 comments
Closed

Find wrong keys with ide-extension #1057

NilsJacobsen opened this issue Jul 11, 2023 · 3 comments
Labels
scope: inlang/cli Related to source-code/cli. scope: inlang/sherlock-vscode Related to source-code/ide-extension. type: improvement Something that can be improved.

Comments

@NilsJacobsen
Copy link
Member

During opening PRs I found a lots of projects that use a wrong key in the code. Like in this PR: labring/sealos#3474 (comment)

This wrong key is not yet appearing in any report. Do we plan to add that somehow? I feel like that could be helpful. What do you guys think?

@inlang/ide-extension @inlang/cli

@maige-app maige-app bot added type: improvement Something that can be improved. scope: inlang/sherlock-vscode Related to source-code/ide-extension. labels Jul 11, 2023
@NilsJacobsen NilsJacobsen added the scope: inlang/cli Related to source-code/cli. label Jul 11, 2023
@felixhaeberle
Copy link
Contributor

felixhaeberle commented Jul 11, 2023

  • The CLI can not detect non-existent keys.
  • The IDE Extension already says that no key is found in the reference language

@NilsJacobsen I don't see any improvements here, or did I miss something?

@NilsJacobsen
Copy link
Member Author

I was searching for the keys manually. Because I wanted to give a better report for the PR. Is there a way of prompting a list of locations in code or files where wrong keys are used?

@felixhaeberle
Copy link
Contributor

Currently, we do not offer such a functionality. This would require scanning the complete repository with a matcher/parser-like approach which we do with the IDE Extension already (messageReferencePatterns).

I suggest converting this issue into a discussion and see if people are using it in the same way as you do and if there is an interest in such a feature, build it.

@opral opral locked and limited conversation to collaborators Jul 11, 2023
@felixhaeberle felixhaeberle converted this issue into discussion #1061 Jul 11, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
scope: inlang/cli Related to source-code/cli. scope: inlang/sherlock-vscode Related to source-code/ide-extension. type: improvement Something that can be improved.
Projects
None yet
Development

No branches or pull requests

2 participants