-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ide-extension for i18next handling #3474
Conversation
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3474 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 8 8
Lines 618 618
=======================================
Hits 451 451
Misses 132 132
Partials 35 35 ☔ View full report in Codecov by Sentry. |
@c121914yu inlang seems to be a good method for i18n, please follow up on this pull request. |
How do I get it started? Because we are using the i18n ally plugin locally. I'm not sure if inlang can be replaced it. |
After merge, you just need to open vscode with the inlang ide-extension installed. It should automatically work.
i18n-ally can also be used as a helper with i18n, but inlang is going for the infrastructure approach, which caught me. What does it mean:
In conclusion, inlang can replace it. Especially with the release of opral/monorepo#960 and opral/monorepo#724. But as I said there is no need to decide (no lock-in). |
I have added the inlang.config.js file locally and have installed the inlang extension. But didn't seem to see much effect. |
The SDK is only relevant if you didn't localize yet.
There shouldn't be anything to change here. You can test if the config is valid with |
This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary. |
inlang did a big update which requires an update on this PR. -> Whats new Should I change it? |
Thank your PR. We will re-evaluate the i18n when we rebuild the architecture in Q4. |
This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary. |
Hi @c121914yu just wanted to check-in if you talked already about i18n in Q4? |
This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary. |
I added the inlang IDE extension to sealos. Helps with handling translation keys and translation linting.
What did I add?
inlang.config.js
to configure where language translations are.vscode
folder so other contributors can use it.How to use it?
Extract Messages (translations)
Extract Messages (translations) via the Inlang: Extract Message code action.
Inline annotations
You can see translations directly in your code. No back-and-forth looking into the translation files themselves. (code example from sealos)
Ootb editor & CLI if needed.