PABLO: store Morton number instead of octant's coordinates #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
PABLO.store.morton
branch
5 times, most recently
from
a46d694
to
970ad78
Compare
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
970ad78
to
f6cac75
Compare
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
f6cac75
to
8bb2b3d
Compare
edoardolombardi
approved these changes
Dec 30, 2020
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
8bb2b3d
to
cfd9506
Compare
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
cfd9506
to
51907df
Compare
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
51907df
to
ed32284
Compare
Octant header should be included before bitpit_communications header, otherwise octants will be streamed in the communication buffer using the standard bitpit operator instead of the custom operator defined for the Octant class.
andrea-iob
force-pushed
the
PABLO.store.morton
branch
from
ed32284
to
2e16ace
Compare
marcocisternino
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing octant's coordinates, we can store the Morton number. This allows to reduce PABLO memory footprint and speeds up neighbour search.
(This branch starts from PABLO.optimize.find.neighbours.)