PABLO: fix evaluation of first layer of ghost on periodic boundaries #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
PABLO.fix.periodic.neighbours
branch
from
0407882
to
3956cc2
Compare
edoardolombardi
approved these changes
Nov 4, 2020
andrea-iob
force-pushed
the
PABLO.fix.periodic.neighbours
branch
2 times, most recently
from
7bae643
to
ad6e9a8
Compare
andrea-iob
force-pushed
the
PABLO.fix.periodic.neighbours
branch
2 times, most recently
from
8b1f876
to
5261a1a
Compare
|
Faces associated with periodic edges/nodes are no longer marked as processor boundaries. |
edoardolombardi
approved these changes
Nov 16, 2020
|
I re-tested the pull and my tests worked well. |
andrea-iob
force-pushed
the
PABLO.fix.periodic.neighbours
branch
from
5261a1a
to
f8b5ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ghost octants there are edge or node neighbours of internal octants were not detected properly on periodic boundaries.
Shuold fix #98.