patchkernel: rework function that adjust cell orientation #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
patchkernel.fix.flip.normals
branch
from
fe7f3db
to
2f67e5f
Compare
marcocisternino
approved these changes
Jan 7, 2021
Cells may be neighbours through multiple faces. To evaluate the adjoin face, first we need to identify all the faces through which the two cells are neighbour and then we need to select the face that matches the target one.
The new implementation properly takes into account border cells, also it doesn't require the interfaces.
…urface with borders
…ne-dimensional surface
andrea-iob
force-pushed
the
patchkernel.fix.flip.normals
branch
from
2f67e5f
to
aafb381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new implementation properly takes into account border cells, also it doesn't require the interfaces.