Fixes and optimization to the evaluation of levelset #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
levelset.normal.evaluation
branch
2 times, most recently
from
c2500d9
to
951c8c3
Compare
andrea-iob
force-pushed
the
levelset.normal.evaluation
branch
from
1f1fdfe
to
05d452d
Compare
|
@marcocisternino @edoardolombardi I've updated sign evaluation, it now uses the pseudo-normal. @haysam It seems to me that function convertBarycentricToFlagPolygon was giving incorrect results when a point was on an edge, does the fix 54cc90e seems right to you? The algorithm used to evaluate the pseudo-normal depends on the location of the point within a triangle:
|
edoardolombardi
approved these changes
Apr 7, 2021
|
👍 New changes passed my tests. |
andrea-iob
force-pushed
the
levelset.normal.evaluation
branch
from
08508b9
to
5af17ed
Compare
…entric coordinates
…ons that search for cell neighbours
…de before setting it
… segment vertices
…ordinates of a vertex
The algorithm used to evaluate the pseudo-normal depends on the location of the point within a triangle: - if the point coincides with a vertex, the pseudo-normal is evaluated as the unlimited normal of the vertex; - if the point lies on an edge, the pseudo-normal is the average of the normals of the two segments sharing the edge; - if the point is inside the segment, the pseudo-normal is evaluated as the normal of the segment.
andrea-iob
force-pushed
the
levelset.normal.evaluation
branch
from
5af17ed
to
5bbe463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These change fixes the selection of surface segments when multiple segments are at the same distance from a cell and introduce some miscellaneous optimizations to the evaluation of the levelset.