Move logger into common module #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
common.logger
branch
8 times, most recently
from
8d1b857
to
5101353
Compare
roccoarpa
approved these changes
Jun 28, 2021
There was a problem hiding this comment.
Modifications are fine for me.
@andrea-iob I've just rebased the pull on the actual master, resolving those conflict on the main CMakeLists and rbf.cpp. Let me know if you want me to push the rebased branch to buy you time.
andrea-iob
force-pushed
the
common.logger
branch
from
5101353
to
bcd403e
Compare
|
I read you message too late, I already did the rebase myself. Thanks anyway. If you want, you can check if the updated branch matches your rebased branch. |
marcocisternino
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the logger in any bitpit module.