patchkernel: optimize vertex duplicate check #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's faster to identify the duplicate vertices using a std:set, rather then using a bitpit::KdTree.
andrea-iob
force-pushed
the
patchkernel.optimize.vertex.duplicate.check
branch
from
ca003c1
to
4c55799
Compare
edoardolombardi
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's faster to perform vertex duplicate checks using a std::set instead of a bitpit::kdtree. For a STL with 3 millions triangles, the time it takes to remove duplicate vertices it's reduced from 16 seconds to 11 seconds.
This optimization also affects patch partitioning: a duplicate vertex check is performed when receiving the vertices.