Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix definition of BITPIT_CMAKE_CONFIG_PATH_LAST variable in BITPITConfig.cmake.in #239

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

roccoarpa
Copy link
Contributor

When bitpit is used as dependency library, BITPIT_CMAKE_CONFIG_PATH_LAST chached internal variable wasn't declared properly. This triggered the reconfigure procedure every time.

roccoarpa and others added 2 commits November 3, 2021 15:47
BITPIT_CMAKE_CONFIG_PATH_LAST internal variable wasn't declared
properly. This triggered the reconfigure procedure every time.
Copy link
Member

@andrea-iob andrea-iob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also fixed the case of bitpit name in the same file (it's bitpit, not BITPIT).

@andrea-iob andrea-iob changed the title cmake: fix cached var in BITPITConfig.cmake.in cmake: fix definition of BITPIT_CMAKE_CONFIG_PATH_LAST variable in BITPITConfig.cmake.in Nov 3, 2021
@marcocisternino marcocisternino merged commit e5b4fec into master Nov 9, 2021
@roccoarpa roccoarpa deleted the fix.BITPITConfig.cmake.in branch November 9, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants