containers: fixed templates for MSVC compiler compliancy #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure on travis build depends on a problem on clang compiler on usage of EnableArgsInitType in template (missing typename). The problem is clang only: code compiles fine on gnu gcc (4.8, 7.3, 9.3) and msvc-vs 2019. Need to investigate more. |
roccoarpa
force-pushed
the
containers.fix.templates.msvc
branch
from
5611d37
to
0ac4838
Compare
|
squashed abovementioned commits after successfull CI. |
MSVC was not able to digest some varyadically templated methods that used std::enable_if directive to trigger SFINAE. Mismatch in overloading was reported. Current solution works on gnu-gcc (4.8, 9.3), llvm-clang(7.0,10.0), and VS2019-msvc cl
The usage of T in declaration of method's arguments triggers an error since MSVC does not resolve T=value_t=<pod specified by the class> in instantiation. In this context, T is used just as a dummy to trigger SFINAE, so it's safe to use directly original class value_t as method argument.
…ass methods According to Visual Studio 2022 documentation (see Compiler Error C2668), "if, in the same class, you have a regular member function and a templated member function with the same signature, the templated one must come first. This limitation remains in the current implementation of Visual C++."
andrea-iob
force-pushed
the
containers.fix.templates.msvc
branch
from
0ac4838
to
6e3fe5b
Compare
andrea-iob
approved these changes
Feb 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull adjusts nomenclature of some templates methods to achieve compliancy with MSVC cl compiler. They do not fix errors in the gnu context, they simply reword methods in an alternative way.
Main mods involve the PiercedStorage/PiercedVector classes (see commits description).
Additionally, rewording on some preprocessor macro was needed (see commit description)