Cramer solvability condition

[marcocisternino]

No description provided.

[alessandro-alaia]

Sounds right since the function det() in "matrix_utilities.tpp" returns a signed determinant.

[andrea-iob]

For consistency with the rest of bitpit, can we use std::abs instead of fabs?

[marcocisternino]

Sure Marco Cisternino, PhD ***@***.******@***.***>

…

______________________ Optimad Engineering Srl Via Bligny 5, Torino, Italia. +3901119719782 www.optimad.it<http://www.optimad.it/> From: Andrea Iob ***@***.***> Sent: giovedì 17 febbraio 2022 18:01 To: optimad/bitpit ***@***.***> Cc: Marco Cisternino ***@***.***>; Author ***@***.***> Subject: Re: [optimad/bitpit] Cramer solvability condition (PR #283) @andrea-iob approved this pull request. For consistency with the rest of bitpit, can we use std::abs instead of fabs? — Reply to this email directly, view it on GitHub<#283 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSMIGB5U5IONG2FUBX6L73U3USV3ANCNFSM5OVGRVNA>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[andrea-iob]

I've replaced fbas with std::abs.