Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

levelset: add support for evaluating the levelset on unstructured grids #293

Merged
merged 18 commits into from
Sep 5, 2022

Conversation

andrea-iob
Copy link
Member

It is now possible to evaluate the levelset on unstructured grids.

@edoardolombardi
Copy link
Member

I don't know the relationship with the pull request, but (at least) tests 1,2,3,4,6 of surfunstructured and tests 1,4 of sunrfunstructured parallel fail.
On master branch all of them pass.

@andrea-iob andrea-iob force-pushed the levelset.unstructured branch 6 times, most recently from 21b6e84 to 9de2262 Compare May 17, 2022 06:50
@andrea-iob
Copy link
Member Author

There were some failures with the leveset tests that are now fixed. I don't see problems with the surfunstructured tests.

Copy link
Member

@edoardolombardi edoardolombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran bitpit tests and reviewed the code. No used in an external application.

@andrea-iob
Copy link
Member Author

Rebased on current master and added support for generic segmentation elements (before the change, only triangles were supported for three-dimensional segmentations).

@andrea-iob andrea-iob force-pushed the levelset.unstructured branch 2 times, most recently from 58c3514 to 31e98c0 Compare July 27, 2022 09:57
@andrea-iob
Copy link
Member Author

The new levelset test was failing because generalized barycentric coordinates cannot be evaluated for degenerate polygons
(i.e. polygons with consecutive collinear edges). We may need to introduce some checks in the CG module to find out if a polygon is degenerate. For now, I slightly modified the geometry of the test case to avoid degenerate polygons.

@andrea-iob andrea-iob merged commit 55fc539 into master Sep 5, 2022
@andrea-iob andrea-iob deleted the levelset.unstructured branch September 5, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants