surfunstructured: use a better estimate of the number of vertices when importing an STL #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n importing an STL
andrea-iob
force-pushed
the
surfunstructured.reduce.memory.usage
branch
from
b6ab2b5
to
6badf57
Compare
edoardolombardi
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of facets and the number of vertices of a triangulation are related by the inequality nFacets <= 2 * nVertices - 4, where the equality holds for a closed triangulation. To limit memory usage in the case the facets are joined, we estimate the number of vertices assuming a closed triangulation (this gives us the minimum number of nodes the triangulation could possibly have).
With this change, there is a 30% reduction in the memory needed for importing a closed triangulation of 500K elements.