Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers: Fix undefined behaviour when flatVector is empty but has items #304

Conversation

DMurataj01
Copy link
Contributor

No description provided.

@DMurataj01 DMurataj01 changed the title Fix undefined behaviour when flatVector is empty but has items containers: Fix undefined behaviour when flatVector is empty but has items May 17, 2022
@andrea-iob andrea-iob self-requested a review May 22, 2022 19:07
Copy link
Member

@andrea-iob andrea-iob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could add the prefix "containers: " to the commit message. This makes easier to spot commits related to a specific module.

I will add this fix also in the upcoming 1.8 version.

src/containers/flatVector2D.tpp Outdated Show resolved Hide resolved
src/containers/flatVector2D.tpp Outdated Show resolved Hide resolved
@andrea-iob andrea-iob self-assigned this May 22, 2022
@andrea-iob andrea-iob added this to the 1.8 milestone May 22, 2022
@DMurataj01 DMurataj01 force-pushed the containers.flatVector.empty.but.has.items branch from ef72c52 to 67b618d Compare May 23, 2022 15:39
@andrea-iob andrea-iob merged commit e0157cb into optimad:master May 24, 2022
@DMurataj01 DMurataj01 deleted the containers.flatVector.empty.but.has.items branch June 9, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants