Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize header inclusion #331

Merged
merged 8 commits into from
Sep 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/LA/system_solvers_large.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ struct KSPStatus {
class SystemMatrixAssembler {

public:
virtual ~SystemMatrixAssembler() = default;

virtual long getRowCount() const = 0;
virtual long getColCount() const = 0;

Expand Down
1 change: 1 addition & 0 deletions src/PABLO/LocalTree.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#include "tree_constants.hpp"
#include "Octant.hpp"
#include "Intersection.hpp"
#include "morton.hpp"

namespace bitpit {

Expand Down
8 changes: 0 additions & 8 deletions src/RBF/rbf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,6 @@ namespace bitpit {
*
*/

/*!
* Destructor
*/
RBFKernel::~RBFKernel()
{
m_fPtr = NULL;
}

/*!
* Default constructor. RBFBasisFunction is WENDLANDC2 by default. RBFMode is
* INTERP, by default. Use setFunction and setMode for changing it.
Expand Down
3 changes: 2 additions & 1 deletion src/RBF/rbf.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,11 @@ class RBFKernel{
int m_nodes; /**<Number of RBF nodes.*/

public:
~RBFKernel();
RBFKernel();
RBFKernel(const RBFKernel & other);

virtual ~RBFKernel() = default;

void setFunction(RBFBasisFunction);
void setFunction(double (&funct)(double ));

Expand Down
2 changes: 0 additions & 2 deletions src/containers/piercedStorageIterator.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
#include <limits>
#include <type_traits>

#include "piercedKernel.hpp"

#define __PSI_REFERENCE__ typename PiercedStorageIterator<value_t, id_t, value_no_cv_t>::reference
#define __PSI_POINTER__ typename PiercedStorageIterator<value_t, id_t, value_no_cv_t>::pointer

Expand Down
3 changes: 3 additions & 0 deletions src/containers/piercedSync.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ class PiercedSyncSlave {

friend class PiercedSyncMaster;

public:
virtual ~PiercedSyncSlave() = default;

protected:
PiercedSyncSlave();

Expand Down
2 changes: 2 additions & 0 deletions src/levelset/levelSetBoundedObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ namespace bitpit {
class LevelSetBoundedObject {

public:
virtual ~LevelSetBoundedObject() = default;

virtual void getBoundingBox( std::array<double,3> &, std::array<double,3> & )const =0 ;
# if BITPIT_ENABLE_MPI
virtual void getGlobalBoundingBox( std::array<double,3> &, std::array<double,3> & )const =0 ;
Expand Down
1 change: 0 additions & 1 deletion src/levelset/levelSetCachedObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@

# include "bitpit_containers.hpp"

# include "levelSetBoundedObject.hpp"
# include "levelSetKernel.hpp"
# include "levelSetSignedObject.hpp"
# include "levelSetStorage.hpp"
Expand Down
2 changes: 0 additions & 2 deletions src/levelset/levelSetMaskObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
# include "bitpit_operators.hpp"
# include "bitpit_surfunstructured.hpp"

# include "levelSetCartesianKernel.hpp"
# include "levelSetOctreeKernel.hpp"
# include "levelSetSegmentationObject.hpp"

namespace bitpit{
Expand Down
2 changes: 2 additions & 0 deletions src/levelset/levelSetObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ class LevelSetKernel;
class LevelSetObjectInterface {

public:
virtual ~LevelSetObjectInterface() = default;

virtual LevelSetKernel * getKernel() = 0;
virtual const LevelSetKernel * getKernel() const = 0;
virtual void setKernel(LevelSetKernel *) = 0;
Expand Down
1 change: 1 addition & 0 deletions src/levelset/levelSetSegmentationObject.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
#include "bitpit_voloctree.hpp"

#include "levelSetCommon.hpp"
#include "levelSetBoundedObject.hpp"
#include "levelSetCachedObject.hpp"
#include "levelSetCartesianKernel.hpp"
#include "levelSetOctreeKernel.hpp"
Expand Down
2 changes: 1 addition & 1 deletion src/patchkernel/volume_mapper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
#include <vector>
#include <unordered_map>

#include "bitpit_patchkernel.hpp"
#include "volume_kernel.hpp"

namespace bitpit {

Expand Down