PABLO: simplify 2:1 balance #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
PABLO.simplify.balance
branch
3 times, most recently
from
54d4456
to
9da552c
Compare
marcocisternino
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
I tested using several complex geometries. Basically, the generated mesh is equal to the mesh generated by the previous version. The max speed up I could see in mesh generation is about 5% of the previous version. The tests have been based on: number of global elements, checking 1:1 of slices of the mesh, comparison by subtraction of global ids, checking of number of the elements and of their configuration level by level.
We must continuously pay the our attention to the effects of this mod, because a lot of unknown configurations should be tested.
If we only need the Morton number, we can just compute the Morton number.
…ance It's simpler to process all the ghosts of the first layer rather than relay on the AUX bit for 2:1 balance. Moreover, that bit was not properly reset and 2:1 balance was check on many more octants than actually needed.
andrea-iob
force-pushed
the
PABLO.simplify.balance
branch
from
2e8a6d5
to
280309b
Compare
|
Rebased on current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten some functions to reduce code duplication. The refactoring removed 1300 lines of code.
There are also some performance improvements. The biggest one is related to the last commit. After the latest code refactoring, it is no more necessary to relay the AUX bit for 2:1 balance. Moreover, that bit was not properly reset and 2:1 balance was check on many more octants than actually needed. This leads to a speed improvement of 25x for the function that perform load balance. All tests pass, however a thorough code review and some more test are needed to make sure the changes are fine.
Original profile of localBalance:
Updated profile of localBalance:
