discretization: fix logic to detect if polynomial storage should be resized #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
discretization.fix.storage.resize
branch
from
2e7c54f
to
e0ea52c
Compare
|
I've put back the CBLAS function in the evaluation of the polynomials. The raeson I was seeing poor performances for small matrices may be related to the fact that I was using an unoptimized BLAS library. |
andrea-iob
force-pushed
the
discretization.fix.storage.resize
branch
from
e0ea52c
to
774dcb9
Compare
|
Rebased on current master. |
marcocisternino
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current storage size was not properly evaluated.
I've also updated the function that evaluates the polynomial coefficients: since the weight matrix is usually small, it's faster perform matrix vector multiplication using an ad-hoc code rather than using CBLAS functions..