common: add message to deprecated macros #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
reviewed
Sep 19, 2022
andrea-iob
reviewed
Sep 19, 2022
edoardolombardi
force-pushed
the
common.add.message.to.deprecated
branch
2 times, most recently
from
7944d01
to
1b5c1c1
Compare
|
Could you please also add "define BITPIT_DEPRECATED_FOR(func, replacement) func" in the else branch? This will allow unsupported compilers to still compile bitpit even if we don't explicitly define a deprecated macro for them. |
edoardolombardi
force-pushed
the
common.add.message.to.deprecated
branch
from
1b5c1c1
to
c254ff5
Compare
andrea-iob
approved these changes
Sep 20, 2022
|
Since we are changing this part of the code, I changed the message displayed when deprecated macros are not implemented ad fixed the indentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new macro to define functions as deprecated with message as input argument.
With this new macros BITPIT_DEPRECATED_FOR (one for each supported compiler as the original ones) is possibile to pass a message to indicate wich method has to be used instead.
Currently compiled and tested only for GNUC case.