IO: miscellaneous fixes for the XML reader/writer #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roccoarpa
requested changes
Sep 26, 2022
There was a problem hiding this comment.
compiling fails:
In member function ‘void bitpit::Config::dump(std::ostream&, int) const’:
.../bitpit/src/IO/configuration_config.cpp:405:41: error: ‘entry’ was not declared in this scope
405 | out << indent << padding << entry.first << " = " << entry.second << std::endl;
Please re-ask me the review when everything is fixed.
andrea-iob
force-pushed
the
io.fix.xml.leaks
branch
from
cb637bd
to
74304cc
Compare
roccoarpa
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same changes of #267 but without the part the add attributes support.