Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voloctree: fix partitioning initialization #369

Merged
merged 5 commits into from
Jan 10, 2023
Merged

voloctree: fix partitioning initialization #369

merged 5 commits into from
Jan 10, 2023

Conversation

andrea-iob
Copy link
Member

The container passed to the function that performs the initial load balance was not the container with the correct weights.

@andrea-iob andrea-iob self-assigned this Dec 21, 2022
marcocisternino
marcocisternino approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@marcocisternino marcocisternino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checked. Apparently a loadBalance without weights was performed always because of m_partitioningOctantWeights nullity

@andrea-iob andrea-iob force-pushed the voloctree.fix.partitioning.initialization branch from 5488466 to 2f3c495 Compare January 10, 2023 09:53
@andrea-iob andrea-iob merged commit 6747063 into master Jan 10, 2023
@andrea-iob andrea-iob deleted the voloctree.fix.partitioning.initialization branch January 10, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcocisternino marcocisternino marcocisternino approved these changes

@edoardolombardi edoardolombardi Awaiting requested review from edoardolombardi

Assignees

@andrea-iob andrea-iob

Labels
bug M - voloctree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrea-iob @marcocisternino