patchkernel: fix evaluation of normal for polygonal elements #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
changed the title
andrea-iob
force-pushed
the
element.eval.normal
branch
from
e79770a
to
8ed2cfd
Compare
|
I've added some comments. |
andrea-iob
force-pushed
the
element.eval.normal
branch
from
8ed2cfd
to
2eac6b6
Compare
andrea-iob
approved these changes
Mar 20, 2023
|
On a second though, the code can be simplified: if the normal is re-normalized, there is no need to divede it by surfaceArea. |
|
The branch "ai.element.eval.normal" contains a simplified version. |
marcocisternino
force-pushed
the
element.eval.normal
branch
from
2eac6b6
to
ba1d430
Compare
Evaluating the normal of a polygonal element as the weighted average of the normals of its tiles will not generate a versor (triangular inequality). After being evaluated, the vector needs to be explicitly normalized.
marcocisternino
force-pushed
the
element.eval.normal
branch
from
ba1d430
to
4e489a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return vector must be normalized to assure to be a versor.