cmake: allow bitpit to be built as a subproject of another cmake project #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
changed the title
andrea-iob
reviewed
Jan 24, 2020
There was a problem hiding this comment.
The changes are fine (tested with cmake 3.13.2 and 3.10.2).
May I ask you to change the commit messages? Something like the following would allow us to better understand what the changes are needed for.
cmake: change CMAKE_PROJECT_NAME into PROJECT_NAME
This is needed in order to allow bitpit to be built as a subproject of another cmake project.
cmake: change the way CMAKE_MODULE_PATH is set in top-level CMakeLists.txt
This is needed in order to allow bitpit to be built as a subproject of another cmake project.
This is needed in order to allow bitpit to be built as a subproject of another cmake project.
This is needed in order to allow bitpit to be built as a subproject of another cmake project.
andrea-iob
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide modifications mentionned in issue #37