Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Voloctree Mapper rank-overlapped ids getter #381

Merged
merged 5 commits into from
May 15, 2023

Conversation

marcocisternino
Copy link
Member

This branch:

  • aligns rank-overlapped reference ids getter (getSentReferenceIds) to the mapped ids ones , by providing non-empty rank lists only
  • changes the return datatype of these getters into an unordered_map
  • introduces a missing getter, specifically the getReceivedReferenceIds method

It has been tested using rank/ids list getters for mesh mapping MPI communications in an application code.

Copy link
Member

@edoardolombardi edoardolombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved only by code review and run of bitpit tests (I've no application using that feature).

@andrea-iob
Copy link
Member

To be consistent with current git history, the portion of the commit title should only contain the name of the module (e.g., "voloctree: ...").

@marcocisternino marcocisternino force-pushed the voloctree.mapper.ref.recv branch 3 times, most recently from 9c97c28 to 813e8c9 Compare May 4, 2023 12:52
@andrea-iob andrea-iob removed their request for review May 11, 2023 15:00
@marcocisternino marcocisternino merged commit 0a9c705 into master May 15, 2023
@marcocisternino marcocisternino deleted the voloctree.mapper.ref.recv branch May 15, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants