patchkernel: rework evaluation of characteristic size of three-dimensional elements #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In some contexts, the updated equations can still provide a size than is larger/smaller that desired. We may want to implement other functions for those specific cases (for example, the levelset provides formulas for evaluating the radius of the tangent sphere or the radius of the bounding sphere). |
The updated formulas are more appropriate when the characteristic size is used for the evaluation of the timestamp in transient simulations.
andrea-iob
force-pushed
the
patchkernel.polyhedron.size
branch
from
42a8029
to
984ab99
Compare
edoardolombardi
approved these changes
Apr 19, 2023
marcocisternino
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated formulas are more appropriate when the characteristic size is used for the evaluation of the timestamp in transient simulations. Also, the evaluation of the characteristic size for polygons and polyhedra was missing.
When no better formula is known, characteristic size is evaluated as the volume divided by the area of the largest face (or by the area divided by the length of the longest face for two-dimensional elements).