Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voloctree: fix performance-move-const-arg clang tidy error in importCells (+ correct local typo) #386

Merged
merged 3 commits into from
Apr 20, 2023
Merged

voloctree: fix performance-move-const-arg clang tidy error in importCells (+ correct local typo) #386

merged 3 commits into from
Apr 20, 2023

Conversation

DMurataj01
Copy link
Contributor

No description provided.

andrea-iob
andrea-iob approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@andrea-iob andrea-iob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine, can you just update the commit message? Something like "voloctree: fix performance-move-const-arg clang tidy error in importCells".

@andrea-iob
Copy link
Member

Out of curiosity, do you have more information on why using a copy is better than using move?

@DMurataj01
Copy link
Contributor Author

Out of curiosity, do you have more information on why using a copy is better than using move?

Not exactly sure, we have clang-tidy as part of our pipeline and this is something which I've had to fixup

@andrea-iob andrea-iob merged commit 411b7db into optimad:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-iob andrea-iob andrea-iob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DMurataj01 @andrea-iob