patchkernel: add a function to check if factes of surface patch have a consistent orientation #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
patchkernel.surface.orientation.consistency
branch
from
5bc26d4
to
1872ca3
Compare
andrea-iob
force-pushed
the
patchkernel.surface.orientation.consistency
branch
from
1872ca3
to
684e52a
Compare
|
I fixed a problem with detection of surface consistency in parallel. |
marcocisternino
approved these changes
Oct 11, 2023
|
@marcocisternino Can you approve the pull request? |
marcocisternino
approved these changes
Oct 12, 2023
|
I was waiting for the pull to be confirmed for review, but I did it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function can be used to check if all the factes of a surface patch are oriented in the same way.
Draft because it need more testing.