PABLO: fix parallel 2:1 balance #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
requested review from
edoardolombardi,
marcocisternino and
ksamouchos
andrea-iob
force-pushed
the
pablo.fix.parallel.2.to.1.balance
branch
from
53069cc
to
7565f32
Compare
ksamouchos
approved these changes
Oct 18, 2023
src/PABLO/ParaTree.cpp
Outdated
| // Balance 2:1 the tree | ||
| // | ||
| // After the first step only ghost octants are checked for balance, that's because | ||
| // during this stemps we only need to propagate the marker across the processes. |
marcocisternino
approved these changes
Oct 18, 2023
andrea-iob
force-pushed
the
pablo.fix.parallel.2.to.1.balance
branch
from
7565f32
to
9b72e42
Compare
edoardolombardi
approved these changes
Oct 19, 2023
The first 2:1 balancing was only checking internal octants, however the balancing algortihm uses marker information from the neighbours of the checked octants and the neighbours could be ghosts octants. It is therefore necessary to exchange the adaption markers before starting balancing a partitioned tree.
andrea-iob
force-pushed
the
pablo.fix.parallel.2.to.1.balance
branch
from
9b72e42
to
e13889a
Compare
|
I changed the commit message to better explain why we need to exchange marker information before starting balancing the tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before starting balancing a partitioned tree, it is necessary to exchange the adaption markers.