patchkernel: fix data types of VTK geometry fields #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
patchkernel.fix.vtk.types
branch
from
ff6c03d
to
dbc00a1
Compare
|
The data type used when flushing vertex index was wrong, I fixed it as well. |
|
For me it's ok, but I leave @haysam approving as author of the module. |
|
@haysam Can I merge this? |
haysam
approved these changes
Apr 3, 2020
Data type of offset field should match the data type of the connectivity.
andrea-iob
force-pushed
the
patchkernel.fix.vtk.types
branch
from
b905c50
to
da482ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data type of offset field should match the data type of the connectivity.
This is the error raised by Paraview 5.8 while opening a VolOctree patch:
@haysam The change to the IO module is not strictly needed to fix the issue because PatchKernel is not using VTK homogeneous grids, but I think we shouldn't set the type of the offset field to UInt64 unconditionally (it may not match the data type of the connectivity field).