patchkernel: keep track of vertices owners #80
Conversation
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
2 times, most recently
from
edb0478
to
1c508b4
Compare
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
2 times, most recently
from
df6ad38
to
9b6e8e8
Compare
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
2 times, most recently
from
4ef01aa
to
f17e9a3
Compare
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
from
f17e9a3
to
1604ed7
Compare
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
from
1604ed7
to
d252360
Compare
| @@ -2947,6 +3234,54 @@ std::vector<int> PatchKernel::getNeighbourRanks() | |||
| return neighRanks; | |||
| } | |||
|
|
|||
| /*! | |||
| Gets a constant reference to the ghost targets needed for data exchange. | |||
|
|
|||
There was a problem hiding this comment.
A comment here can help to understand better what are ghost targets. Something like:
For each source rank (key of the returned map) the ordered list of the local ids of the ghost vertices is provided. These vertices are involved as targets in a send/receive data exchange. Targets ghost vertices on a receiving rank have the same order of the source vertices on the related sending rank.
Maybe, it can be written more clearly....
|
|
||
| /*! | ||
| Gets a constant reference to the ghost sources needed for data exchange. | ||
|
|
There was a problem hiding this comment.
The same as for target vertices.
Here, we can also add a comment explaining that the sources are internal vertices and not ghost vertices.
Sources ids are the ids of the local vertices, owned by the current rank, that are involved as sources in data exchange for each receving rank.
| // | ||
| // Identify exchange sources | ||
| // | ||
| // Since vertices are shared among elements, data exchange does not involve |
There was a problem hiding this comment.
This comment is really clear, maybe can be included in some method documentation?
For instance in a getGhostTarget/SourceVertexExchangeInfo()? Or in the documentation of this method?
Does it make sense?
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
2 times, most recently
from
f3223b7
to
bc893c6
Compare
…of 'restoreVertex'
…only for non-MPI builds
andrea-iob
force-pushed
the
patchkernel.ghost.vertices
branch
from
bc893c6
to
32bde41
Compare
Each vertex is now associated with a processor, that processor is the owner of the vertex. Given the owners of the cells in one-ring neighborhood of a vertex, the owner of the vertex is the processor with the lowest rank.
Like for the cells, data structures for ghost data exchange are built also for the vertices.