Pin cyipopt to version 1.2 or smaller and fix ruff complaints

optimagic-dev · Oct 25, 2023 · 31bc910 · 31bc910
1 parent 4823580
commit 31bc910
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/environment.yml b/environment.yml
@@ -5,7 +5,7 @@ channels:
   - nodefaults
 dependencies:
   - python=3.10  # dev
-  - cyipopt  # dev
+  - cyipopt<1.3.0  # dev
   - jupyterlab  # dev, docs
   - nb_black  # dev, docs
   - nlopt  # dev, tests

diff --git a/src/estimagic/visualization/estimation_table.py b/src/estimagic/visualization/estimation_table.py
@@ -1240,8 +1240,9 @@ def _generate_notes_latex(
                     raise ValueError(
                         f"""Each custom note can only be of string type.
                         The following notes:
-                        {[n for n in custom_notes if type(n) != str]} are of types
-                        {[type(n) for n in custom_notes if type(n) != str]}
+                        {[n for n in custom_notes if not isinstance(n, str)]} are of
+                        types
+                        {[type(n) for n in custom_notes if not isinstance(n, str)]}
                         respectively."""
                     )
                 for n in custom_notes:
@@ -1300,8 +1301,9 @@ def _generate_notes_html(
                     raise ValueError(
                         f"""Each custom note can only be of string type.
                         The following notes:
-                        {[n for n in custom_notes if type(n) != str]} are of types
-                        {[type(n) for n in custom_notes if type(n) != str]}
+                        {[n for n in custom_notes if not isinstance(n, str)]} are of
+                        types
+                        {[type(n) for n in custom_notes if not isinstance(n, str)]}
                         respectively."""
                     )
                 notes_text += """