Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pounders filtering to tranquilo #389

Merged
merged 36 commits into from
Oct 30, 2022
Merged

Add pounders filtering to tranquilo #389

merged 36 commits into from
Oct 30, 2022

Conversation

segsell
Copy link
Member

@segsell segsell commented Oct 12, 2022

  • Fix bug in Pounders fitting
  • Make Tranquilo more flexible
  • Add pounders filtering
  • Refactor
  • Write more tests

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #389 (74aa852) into main (0cd0b18) will increase coverage by 0.03%.
The diff coverage is 87.03%.

@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
+ Coverage   92.60%   92.63%   +0.03%     
==========================================
  Files         207      208       +1     
  Lines       16100    16372     +272     
==========================================
+ Hits        14909    15167     +258     
- Misses       1191     1205      +14     
Impacted Files Coverage Δ
tests/optimization/test_pounders_integration.py 92.45% <ø> (ø)
tests/optimization/tranquilo/test_fit_models.py 78.89% <58.92%> (-21.11%) ⬇️
src/estimagic/optimization/tranquilo/tranquilo.py 90.47% <79.54%> (-1.38%) ⬇️
.../estimagic/optimization/tranquilo/filter_points.py 80.00% <82.35%> (+13.33%) ⬆️
src/estimagic/optimization/tranquilo/fit_models.py 83.53% <92.30%> (+5.24%) ⬆️
...stimagic/benchmarking/process_benchmark_results.py 95.55% <100.00%> (ø)
...timagic/optimization/tranquilo/aggregate_models.py 87.71% <100.00%> (+4.11%) ⬆️
src/estimagic/optimization/tranquilo/models.py 100.00% <100.00%> (ø)
...ts/optimization/tranquilo/test_aggregate_models.py 100.00% <100.00%> (ø)
tests/optimization/tranquilo/test_filter_points.py 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg self-requested a review October 30, 2022 16:44
Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I ran some benchmarks on the different fitting methods and settled on fit_pounders_experimental. The differences are small but it is better in some cases.

@janosg janosg merged commit 4b9019f into main Oct 30, 2022
@janosg janosg deleted the filtering branch October 30, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants