-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pounders filtering to tranquilo #389
Conversation
segsell
commented
Oct 12, 2022
•
edited
Loading
edited
- Fix bug in Pounders fitting
- Make Tranquilo more flexible
- Add pounders filtering
- Refactor
- Write more tests
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
+ Coverage 92.60% 92.63% +0.03%
==========================================
Files 207 208 +1
Lines 16100 16372 +272
==========================================
+ Hits 14909 15167 +258
- Misses 1191 1205 +14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I ran some benchmarks on the different fitting methods and settled on fit_pounders_experimental
. The differences are small but it is better in some cases.