-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tranquilo code #395
Conversation
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 92.62% 92.73% +0.10%
==========================================
Files 208 209 +1
Lines 16372 16484 +112
==========================================
+ Hits 15165 15286 +121
+ Misses 1207 1198 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We will tackle problems 1. and 2. in separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice refactoring PR! The test modules look way cleaner now. And great job finding out that np.linalg.lstsq
is more robust than np.linalg.sovle
in powell_fitting
. Thank you!!
The powell fitting benchmarks (scalar case) now look slightly worse switching from |
test_tranquilo.py
.models.py
.