Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several small improvements #412

Merged
merged 10 commits into from
Nov 19, 2022
Merged

Several small improvements #412

merged 10 commits into from
Nov 19, 2022

Conversation

janosg
Copy link
Member

@janosg janosg commented Nov 19, 2022

  • Document how to provide derivatives for nonlinear constraints
  • Return more information when the fides optimizers is used
  • Fix warnings in tests

solves #409
solves #405

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #412 (8cabec9) into main (8ce1611) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   92.86%   92.87%           
=======================================
  Files         223      223           
  Lines       17443    17450    +7     
=======================================
+ Hits        16199    16206    +7     
  Misses       1244     1244           
Impacted Files Coverage Δ
...timagic/optimization/subsolvers/_steihaug_toint.py 80.89% <ø> (ø)
src/estimagic/optimization/subsolvers/_trsbox.py 84.95% <ø> (ø)
src/estimagic/optimization/tiktak.py 92.63% <ø> (ø)
tests/optimization/subsolvers/test_bntr_fast.py 100.00% <ø> (ø)
tests/optimization/subsolvers/test_gqtpar_fast.py 100.00% <ø> (ø)
...sts/optimization/subsolvers/test_gqtpar_lambdas.py 100.00% <ø> (ø)
src/estimagic/inference/shared.py 99.36% <100.00%> (+<0.01%) ⬆️
src/estimagic/optimization/fides_optimizers.py 93.87% <100.00%> (+0.54%) ⬆️
...gic/optimization/subsolvers/_conjugate_gradient.py 100.00% <100.00%> (ø)
src/estimagic/optimization/subsolvers/bntr.py 87.20% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg requested a review from mpetrosian November 19, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants