Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make logging compatible with sqlalchemy 2.0. #432

Merged
merged 10 commits into from
Feb 7, 2023
Merged

Make logging compatible with sqlalchemy 2.0. #432

merged 10 commits into from
Feb 7, 2023

Conversation

janosg
Copy link
Member

@janosg janosg commented Feb 6, 2023

closes #431

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #432 (4d11b71) into main (b651439) will increase coverage by 0.02%.
The diff coverage is 90.03%.

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   92.84%   92.87%   +0.02%     
==========================================
  Files         231      234       +3     
  Lines       17590    17591       +1     
==========================================
+ Hits        16332    16337       +5     
+ Misses       1258     1254       -4     
Impacted Files Coverage Δ
src/estimagic/optimization/tiktak.py 92.45% <ø> (ø)
...test_internal_criterion_and_derivative_template.py 94.36% <ø> (ø)
src/estimagic/logging/write_to_database.py 73.68% <73.68%> (ø)
src/estimagic/logging/load_database.py 84.05% <84.05%> (ø)
src/estimagic/logging/read_from_database.py 88.88% <88.88%> (ø)
src/estimagic/logging/create_tables.py 96.42% <96.42%> (ø)
src/estimagic/dashboard/callbacks.py 58.13% <100.00%> (ø)
src/estimagic/dashboard/dashboard_app.py 100.00% <100.00%> (ø)
src/estimagic/logging/read_log.py 95.72% <100.00%> (+0.64%) ⬆️
src/estimagic/optimization/get_algorithm.py 92.18% <100.00%> (+0.06%) ⬆️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@janosg janosg merged commit 9acf723 into main Feb 7, 2023
@janosg janosg deleted the fix-sql branch February 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging fails with SQLAlchemy 2.0
2 participants