Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace fuzzywuzzy #437

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Replace fuzzywuzzy #437

merged 6 commits into from
Feb 17, 2023

Conversation

aidatak97
Copy link
Contributor

Rewrote the propose_alternatives function using difflib
Added some simple unit tests for it
Removed fuzzywuzzy from environment.yml and setup.cfg

@aidatak97 aidatak97 requested a review from janosg February 14, 2023 18:31
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #437 (d4df55b) into main (9acf723) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   92.87%   92.86%   -0.02%     
==========================================
  Files         234      234              
  Lines       17591    17596       +5     
==========================================
+ Hits        16338    16340       +2     
- Misses       1253     1256       +3     
Impacted Files Coverage Δ
src/estimagic/utilities.py 94.87% <100.00%> (-0.05%) ⬇️
tests/test_utilities.py 98.08% <100.00%> (+0.07%) ⬆️
src/estimagic/optimization/subsolvers/_trsbox.py 84.95% <0.00%> (-0.82%) ⬇️
src/estimagic/optimization/subsolvers/bntr.py 86.38% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janosg janosg merged commit a5bab0c into main Feb 17, 2023
@janosg janosg deleted the replace_fuzzywuzzy branch February 17, 2023 10:26
@janosg janosg mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants