Add functionality to Region class #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cleanup #444 +/- ##
===========================================
+ Coverage 92.95% 92.97% +0.02%
===========================================
Files 244 248 +4
Lines 18373 18508 +135
===========================================
+ Hits 17078 17208 +130
- Misses 1295 1300 +5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
janosg
reviewed
Mar 11, 2023
janosg
reviewed
Mar 13, 2023
timmens
commented
Mar 13, 2023
Comment on lines
+73
to
+75
| deviations.groupby(["algorithm", "n_evaluations"]) | ||
| .mean(numeric_only=True)[outcome] | ||
| .reset_index() |
There was a problem hiding this comment.
Response to deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I extend the functionality of the Region class. I create modules region.py and bounds.py and add tests for their private functions and classes.
The biggest change happened to the
Regionclass. Which is now adataclassobject with attributes (center, radius, bounds); properties (shape, cube_bounds, cube_center) and methods (map_to_unit, map_from_unit). The properties are dynamically updated based on the center, radius and the user-provided bounds. If any of the bounds is binding we switch from a spherical trustregion shape to a cube one. The methodsmap_to_unitandmap_from_unitmap points from the trustregion to the unit space and back. They are attached to this class because they are used in multiple modules and only depend on the information stored in the trustregion.