Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tranquilo an optional dependency #464

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Make tranquilo an optional dependency #464

merged 6 commits into from
Jun 5, 2023

Conversation

janosg
Copy link
Member

@janosg janosg commented May 20, 2023

  • Remove all files related to tranquilo
  • Add importing from tranquilo package
  • Remove numba as estimagic depedency
    • Make sure it is not used anywhere else in estimagic
  • Add Python 3.11 to CI
  • Update changelog

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #464 (b23ffcb) into main (dfc968c) will decrease coverage by 0.73%.
The diff coverage is 86.48%.

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   93.17%   92.44%   -0.73%     
==========================================
  Files         246      192      -54     
  Lines       17937    14591    -3346     
==========================================
- Hits        16712    13489    -3223     
+ Misses       1225     1102     -123     
Impacted Files Coverage Δ
tests/optimization/test_quadratic_subsolvers.py 100.00% <ø> (ø)
src/estimagic/config.py 75.60% <60.00%> (-2.17%) ⬇️
src/estimagic/optimization/tranquilo.py 88.88% <88.88%> (ø)
src/estimagic/algorithms.py 100.00% <100.00%> (ø)
src/estimagic/benchmarking/run_benchmark.py 92.30% <100.00%> (ø)
src/estimagic/optimization/get_algorithm.py 92.24% <100.00%> (-0.87%) ⬇️
tests/optimization/test_history_collection.py 98.41% <100.00%> (ø)
tests/optimization/test_many_algorithms.py 100.00% <100.00%> (ø)
...ts/optimization/test_with_nonlinear_constraints.py 73.25% <100.00%> (ø)

... and 3 files with indirect coverage changes

@janosg janosg requested a review from timmens June 5, 2023 15:22
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, approved! I only have two minor remarks.

pyproject.toml Show resolved Hide resolved
src/estimagic/algorithms.py Show resolved Hide resolved
@janosg janosg merged commit d25d4c2 into main Jun 5, 2023
@janosg janosg deleted the cleanup branch June 5, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants