Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass bootstrap_kwargs to bootstrap call in get_moments_cov #473

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Conversation

timmens
Copy link
Member

@timmens timmens commented Oct 25, 2023

Fixes #472 and adds a test case.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5deb5a2) 92.96% compared to head (6f19b20) 92.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   92.96%   92.97%           
=======================================
  Files         193      193           
  Lines       14620    14631   +11     
=======================================
+ Hits        13592    13603   +11     
  Misses       1028     1028           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timmens timmens requested review from janosg and removed request for janosg October 25, 2023 14:28
@timmens
Copy link
Member Author

timmens commented Oct 25, 2023

Waiting for #471 to be merged.

@timmens timmens changed the title Pass bootstrap_kwargs to bootstrap call get_moments_cov Pass bootstrap_kwargs to bootstrap call in get_moments_cov Oct 25, 2023
@timmens timmens merged commit 50c15c3 into main Dec 29, 2023
15 checks passed
@timmens timmens deleted the bootstrap branch December 29, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_moments_cov does not forward bootstrap_kwargs to bootstrap
2 participants